Guard against malloc failures when configure ALPN and NPN#958
Merged
normanmaurer merged 1 commit intomainfrom Mar 20, 2026
Merged
Guard against malloc failures when configure ALPN and NPN#958normanmaurer merged 1 commit intomainfrom
normanmaurer merged 1 commit intomainfrom
Conversation
Motivation: We missed to check for failed malloc and so could end up with a crash in the rare cause of running out of memory. Modifications: Add NULL checks and throw OOME Result: Both setNpnProtos0 and setAlpnProtos0 now check the OPENSSL_malloc return value before writing the length or calling GetByteArrayRegion. Note that c->next_proto_len / c->alpn_proto_len is also moved to after the NULL check — previously it was written even when the allocation had failed, which would leave the struct in an inconsistent state (non-zero length, NULL data pointer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We missed to check for failed malloc and so could end up with a crash in the rare cause of running out of memory.
Modifications:
Add NULL checks and throw OOME
Result:
Both setNpnProtos0 and setAlpnProtos0 now check the OPENSSL_malloc return value before writing the length or calling GetByteArrayRegion.
Note that c->next_proto_len / c->alpn_proto_len is also moved to after the NULL check — previously it was written even when the allocation
had failed, which would leave the struct in an inconsistent state (non-zero length, NULL data pointer).