Allow neuro port-forward to accept multiple local-remote port pairs by anayden · Pull Request #695 · neuro-inc/apolo-cli

anayden · 2019-04-08T15:42:36Z

Fixes #632

atemate · 2019-04-08T16:01:41Z

+        "",
+    ],
+)
+def test_local_remote_port_param_type_invalid(arg) -> None:


still, I prefer parametrized tests as they are more clear and concise :)

Happy debugging!
Size of a test suite is never a priority :)

asvetlov · 2019-04-09T10:39:52Z

please merge the current master into PR branch

codecov · 2019-04-09T11:18:30Z

Codecov Report

Merging #695 into master will increase coverage by 0.95%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   90.58%   91.54%   +0.95%     
==========================================
  Files          39       40       +1     
  Lines        3103     3263     +160     
  Branches      435      450      +15     
==========================================
+ Hits         2811     2987     +176     
+ Misses        218      207      -11     
+ Partials       74       69       -5

Impacted Files	Coverage Δ
neuromation/cli/utils.py	`92.09% <100%> (+1.45%)`	⬆️
neuromation/api/jobs.py	`92.58% <50%> (-0.58%)`	⬇️
neuromation/cli/job.py	`91.3% <95%> (-1.4%)`	⬇️
neuromation/api/config.py	`95.23% <0%> (-4.77%)`	⬇️
neuromation/cli/main.py	`57.36% <0%> (-1.83%)`	⬇️
neuromation/cli/config.py	`87.01% <0%> (-0.49%)`	⬇️
neuromation/api/core.py	`98.14% <0%> (-0.19%)`	⬇️
neuromation/cli/version_utils.py	`93.22% <0%> (-0.12%)`	⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010d371...d82e5a5. Read the comment docs.

Bumps [towncrier](https://github.com/twisted/towncrier) from 24.8.0 to 25.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/releases">towncrier's releases</a>.</em></p> <blockquote> <h2>Towncrier 25.8.0</h2> <h1>towncrier 25.8.0 (2025-08-30)</h1> <h2>Features</h2> <ul> <li>Support was added for Mercurial SCM. (<code>[#394](twisted/towncrier#394) <https://github.com/twisted/towncrier/issues/394></code>_)</li> <li>The <code>towncrier check</code> command now has a <code>--staged</code> flag to inspect the files staged for commit when checking for a news fragment: useful in a pre-commit hook (<code>[#676](twisted/towncrier#676) <https://github.com/twisted/towncrier/issues/676></code>_)</li> <li>When used with an <code>pyproject.toml</code> file, when no explicit values are defined for [tool.towncrier.name|package] they will now fallback to the value of [project.name]. (<code>[#687](twisted/towncrier#687) <https://github.com/twisted/towncrier/issues/687></code>_)</li> <li>More simple configuration for Keep a Changelog style changelogs (<code>[#691](twisted/towncrier#691) <https://github.com/twisted/towncrier/issues/691></code>_)</li> <li>Added support for Python 3.13 and removed support for Python 3.8. (<code>[#700](twisted/towncrier#700) <https://github.com/twisted/towncrier/issues/700></code>_)</li> </ul> <h2>Bugfixes</h2> <ul> <li>Multi-line newsfragments that ends with a code block will now have a newline inserted before appending the link to the issue, to avoid breaking formatting. (<code>[#614](twisted/towncrier#614) <https://github.com/twisted/towncrier/issues/614></code>_)</li> <li>Markdown header level is correctly inferred from <code>title_format</code>. (<code>[#695](twisted/towncrier#695) <https://github.com/twisted/towncrier/issues/695></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The documentation RST source files are now included in the sdist package. (<code>[#672](twisted/towncrier#672) <https://github.com/twisted/towncrier/issues/672></code>_)</li> <li>Refactor the default markdown template to make it easier to understand, extend, and customize. (<code>[#706](twisted/towncrier#706) <https://github.com/twisted/towncrier/issues/706></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>When no sections are present, the default Markdown template now renders the category headers as H2. In previous versions it was rendered as H3. (<code>[#663](twisted/towncrier#663) <https://github.com/twisted/towncrier/issues/663></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[#667](twisted/towncrier#667) <https://github.com/twisted/towncrier/issues/667></code><em>, <code>[#669](twisted/towncrier#669) <https://github.com/twisted/towncrier/issues/669></code></em>, <code>[#679](twisted/towncrier#679) <https://github.com/twisted/towncrier/issues/679></code><em>, <code>[#680](twisted/towncrier#680) <https://github.com/twisted/towncrier/issues/680></code></em>, <code>[#682](twisted/towncrier#682) <https://github.com/twisted/towncrier/issues/682></code><em>, <code>[#701](twisted/towncrier#701) <https://github.com/twisted/towncrier/issues/701></code></em>, <code>[#702](twisted/towncrier#702) <https://github.com/twisted/towncrier/issues/702></code><em>, <code>[#713](twisted/towncrier#713) <https://github.com/twisted/towncrier/issues/713></code></em></li> </ul> <h2>Towncrier 25.8.0rc2</h2> <h1>towncrier 25.8.0rc2 (2025-08-15)</h1> <h2>Features</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's changelog</a>.</em></p> <blockquote> <h1>towncrier 25.8.0 (2025-08-30)</h1> <p>No significant changes since the previous release candidate.</p> <h2>Features</h2> <ul> <li>Support was added for Mercurial SCM. (<code>[#394](twisted/towncrier#394) <https://github.com/twisted/towncrier/issues/394></code>_)</li> <li>The :command:<code>towncrier check</code> command now has a <code>--staged</code> flag to inspect the files staged for commit when checking for a news fragment: useful in a pre-commit hook (<code>[#676](twisted/towncrier#676) <https://github.com/twisted/towncrier/issues/676></code>_)</li> <li>When used with an :file:<code>pyproject.toml</code> file, when no explicit values are defined for <code>[tool.towncrier.name|package]</code> they will now fallback to the value of <code>[project.name]</code>. (<code>[#687](twisted/towncrier#687) <https://github.com/twisted/towncrier/issues/687></code>_)</li> <li>The <code>directory</code> configuration option is no longer required. It can now be generated based on value from the <code>name</code> configuration. (<code>[#691](twisted/towncrier#691) <https://github.com/twisted/towncrier/issues/691></code>_)</li> <li>Added support for Python 3.13 and removed support for Python 3.8. (<code>[#700](twisted/towncrier#700) <https://github.com/twisted/towncrier/issues/700></code>_)</li> </ul> <h2>Bugfixes</h2> <ul> <li>Multi-line news fragments that end with a code block will now have a newline inserted before appending the link to the issue, to avoid breaking formatting. (<code>[#614](twisted/towncrier#614) <https://github.com/twisted/towncrier/issues/614></code>_)</li> <li>Markdown header level is correctly inferred from <code>title_format</code>. (<code>[#695](twisted/towncrier#695) <https://github.com/twisted/towncrier/issues/695></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The documentation RST source files are now included in the sdist package. (<code>[#672](twisted/towncrier#672) <https://github.com/twisted/towncrier/issues/672></code>_)</li> <li>Refactor the default markdown template to make it easier to understand, extend, and customize. (<code>[#706](twisted/towncrier#706) <https://github.com/twisted/towncrier/issues/706></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>Support for Python 3.8 was removed. (<code>[#700](twisted/towncrier#700) <https://github.com/twisted/towncrier/issues/700></code>_)</li> <li>When no sections are present, the default Markdown template now renders the category headers as H2. In previous versions it was rendered as H3. (<code>[#663](twisted/towncrier#663) <https://github.com/twisted/towncrier/issues/663></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[#667](twisted/towncrier#667) <https://github.com/twisted/towncrier/issues/667></code><em>, <code>[#669](twisted/towncrier#669) <https://github.com/twisted/towncrier/issues/669></code></em>, <code>[#679](twisted/towncrier#679) <https://github.com/twisted/towncrier/issues/679></code><em>, <code>[#680](twisted/towncrier#680) <https://github.com/twisted/towncrier/issues/680></code></em>, <code>[#682](twisted/towncrier#682) <https://github.com/twisted/towncrier/issues/682></code><em>, <code>[#701](twisted/towncrier#701) <https://github.com/twisted/towncrier/issues/701></code></em>, <code>[#702](twisted/towncrier#702) <https://github.com/twisted/towncrier/issues/702></code><em>, <code>[#713](twisted/towncrier#713) <https://github.com/twisted/towncrier/issues/713></code></em></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twisted/towncrier/commit/762c8f28d625979812db33b9446c24bee701ba0b"><code>762c8f2</code></a> Prepare final version.</li> <li><a href="https://github.com/twisted/towncrier/commit/fb2c84213a578aaefc52f02d318b93a3679254bc"><code>fb2c842</code></a> Update NEWS.rst</li> <li><a href="https://github.com/twisted/towncrier/commit/aae1d3307bda638ced5dc9da2a0ef09d02962902"><code>aae1d33</code></a> Apply suggestions from code review</li> <li><a href="https://github.com/twisted/towncrier/commit/cb696b2237e0840b171eb872ce7f5608295f9b80"><code>cb696b2</code></a> [pre-commit.ci] auto fixes from pre-commit.com hooks</li> <li><a href="https://github.com/twisted/towncrier/commit/10bbd8e5e8443bf1f0abe20fe07839302cef747f"><code>10bbd8e</code></a> Fix version string.</li> <li><a href="https://github.com/twisted/towncrier/commit/5f4639a55ba0a68da0146b000e0772bb9947a2cf"><code>5f4639a</code></a> Merge origin.</li> <li><a href="https://github.com/twisted/towncrier/commit/234ebc5dbc43f7f8539c053135cec6a5773449f3"><code>234ebc5</code></a> Fix version.</li> <li><a href="https://github.com/twisted/towncrier/commit/8547ca9a201be62f64c577d032b18aca6409e6b6"><code>8547ca9</code></a> Update releae candidate.</li> <li><a href="https://github.com/twisted/towncrier/commit/5347588877a5447d0ef01dd2093e445d74e8a583"><code>5347588</code></a> [pre-commit.ci] auto fixes from pre-commit.com hooks</li> <li><a href="https://github.com/twisted/towncrier/commit/e5853c5dd1ef69c05a66e9ac5f36f364725b458d"><code>e5853c5</code></a> Update releae candidate.</li> <li>Additional commits viewable in <a href="https://github.com/twisted/towncrier/compare/24.8.0...25.8.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=towncrier&package-manager=pip&previous-version=24.8.0&new-version=25.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

anayden assigned atemate and shagren Apr 8, 2019

anayden requested a review from asvetlov April 8, 2019 15:42

astaff added the platform label Apr 8, 2019

anayden changed the title ~~Allow neuro port-forward to accept multiple local-remote port pairs~~ WIP: Allow neuro port-forward to accept multiple local-remote port pairs Apr 8, 2019

atemate reviewed Apr 8, 2019

View reviewed changes

Comment thread neuromation/cli/utils.py Outdated

atemate reviewed Apr 8, 2019

View reviewed changes

Comment thread neuromation/cli/utils.py Outdated

atemate reviewed Apr 8, 2019

View reviewed changes

Comment thread neuromation/client/jobs.py

atemate reviewed Apr 8, 2019

View reviewed changes

Comment thread neuromation/cli/job.py

anayden force-pushed the an/multiple-port-forward branch from 9964842 to 86a5371 Compare April 9, 2019 11:18

anayden force-pushed the an/multiple-port-forward branch from b26c755 to a854cdd Compare April 9, 2019 13:38

anayden changed the title ~~WIP: Allow neuro port-forward to accept multiple local-remote port pairs~~ Allow neuro port-forward to accept multiple local-remote port pairs Apr 9, 2019

asvetlov approved these changes Apr 10, 2019

View reviewed changes

anayden added 6 commits April 12, 2019 02:25

Allow neuro port-forward to accept multiple local-remote port pairs

302fe0c

Update changelog

9489d7a

Fix e2e test for error case

2a62e31

Address code review comments

1b4263b

Address code review comments

2388473

Increase code coverage

19d31a4

anayden force-pushed the an/multiple-port-forward branch from a854cdd to 19d31a4 Compare April 12, 2019 09:29

Fix readme

d82e5a5

anayden merged commit bb308b7 into master Apr 12, 2019

anayden deleted the an/multiple-port-forward branch April 12, 2019 13:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow neuro port-forward to accept multiple local-remote port pairs#695

Allow neuro port-forward to accept multiple local-remote port pairs#695
anayden merged 7 commits intomasterfrom
an/multiple-port-forward

anayden commented Apr 8, 2019 •

edited by asvetlov

Loading

Uh oh!

Uh oh!

Uh oh!

atemate Apr 8, 2019

Uh oh!

asvetlov Apr 9, 2019

Uh oh!

Uh oh!

Uh oh!

asvetlov commented Apr 9, 2019

Uh oh!

codecov Bot commented Apr 9, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

anayden commented Apr 8, 2019 • edited by asvetlov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atemate Apr 8, 2019

Choose a reason for hiding this comment

Uh oh!

asvetlov Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

asvetlov commented Apr 9, 2019

Uh oh!

codecov Bot commented Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anayden commented Apr 8, 2019 •

edited by asvetlov

Loading

codecov Bot commented Apr 9, 2019 •

edited

Loading