Conversation
failing on: from neuron.rxd.geometry3d import graphicsPrimitives
|
✔️ 71d0c5f -> artifacts URL |
|
✔️ 6287d70 -> artifacts URL |
|
✔️ 6287d70 -> Azure artifacts URL |
|
✔️ 8a96a8b -> artifacts URL |
|
✔️ 6b95fe3 -> artifacts URL |
|
✔️ ece47a1 -> artifacts URL |
|
✔️ 529a0e8 -> artifacts URL |
|
✔️ 5d91d74 -> artifacts URL |
|
✔️ 88a388f -> artifacts URL |
|
✔️ 88a388f -> Azure artifacts URL |
|
✔️ e0d083a -> artifacts URL |
|
✔️ c1f2b22 -> artifacts URL |
|
✔️ c1f2b22 -> Azure artifacts URL |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3564 +/- ##
==========================================
+ Coverage 68.36% 68.45% +0.08%
==========================================
Files 684 681 -3
Lines 116681 116608 -73
==========================================
+ Hits 79766 79821 +55
+ Misses 36915 36787 -128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The rationale for all this is that cleaning up the code will make it easier to work on it further. In particular, the mesh creation for CTNG could be done in parallel (although this is a little complicated by the flood fill approach, but we could definitely do it for the surface voxels). |
nrnhines
left a comment
There was a problem hiding this comment.
Not that I fully understand but this approval allows you to keep moving forward :)
|
✔️ 624b572 -> artifacts URL |
|
✔️ 624b572 -> Azure artifacts URL |
|
✔️ d6ccecd -> artifacts URL |
|
✔️ d6ccecd -> Azure artifacts URL |
|
✔️ 2bbe75b -> artifacts URL |
|
✔️ 2bbe75b -> Azure artifacts URL |
|
|
✔️ 1f59aca -> artifacts URL |
|
✔️ 7a98c1d -> artifacts URL |
|
✔️ 7a98c1d -> Azure artifacts URL |



Removed legacy code, updated to Cython3, refactored large functions, updated string formatting to use f-strings.