Skip to content

Comments

CTNG cleanup#3564

Open
ramcdougal wants to merge 36 commits intomasterfrom
ctngcleanup
Open

CTNG cleanup#3564
ramcdougal wants to merge 36 commits intomasterfrom
ctngcleanup

Conversation

@ramcdougal
Copy link
Member

@ramcdougal ramcdougal commented Aug 10, 2025

Removed legacy code, updated to Cython3, refactored large functions, updated string formatting to use f-strings.

@ramcdougal ramcdougal added wip rxd reaction-diffusion cython labels Aug 10, 2025
@ramcdougal ramcdougal marked this pull request as draft August 10, 2025 16:09
@github-actions
Copy link
Contributor

✔️ 71d0c5f -> artifacts URL

@github-actions
Copy link
Contributor

✔️ 6287d70 -> artifacts URL

@azure-pipelines
Copy link

✔️ 6287d70 -> Azure artifacts URL

@github-actions
Copy link
Contributor

✔️ 8a96a8b -> artifacts URL

@github-actions
Copy link
Contributor

✔️ 6b95fe3 -> artifacts URL

@github-actions
Copy link
Contributor

✔️ ece47a1 -> artifacts URL

@github-actions
Copy link
Contributor

✔️ 529a0e8 -> artifacts URL

@github-actions
Copy link
Contributor

✔️ 5d91d74 -> artifacts URL

@github-actions
Copy link
Contributor

✔️ 88a388f -> artifacts URL

@azure-pipelines
Copy link

✔️ 88a388f -> Azure artifacts URL

@github-actions
Copy link
Contributor

✔️ e0d083a -> artifacts URL

@github-actions
Copy link
Contributor

✔️ c1f2b22 -> artifacts URL

@azure-pipelines
Copy link

✔️ c1f2b22 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.45%. Comparing base (cb7e00c) to head (7a98c1d).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...lib/python/neuron/rxd/geometry3d/triangularMesh.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
+ Coverage   68.36%   68.45%   +0.08%     
==========================================
  Files         684      681       -3     
  Lines      116681   116608      -73     
==========================================
+ Hits        79766    79821      +55     
+ Misses      36915    36787     -128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ramcdougal
Copy link
Member Author

The rationale for all this is that cleaning up the code will make it easier to work on it further. In particular, the mesh creation for CTNG could be done in parallel (although this is a little complicated by the flood fill approach, but we could definitely do it for the surface voxels).

@ramcdougal ramcdougal removed the wip label Aug 12, 2025
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I fully understand but this approval allows you to keep moving forward :)

@github-actions
Copy link
Contributor

✔️ 624b572 -> artifacts URL

@azure-pipelines
Copy link

✔️ 624b572 -> Azure artifacts URL

@github-actions
Copy link
Contributor

✔️ d6ccecd -> artifacts URL

@azure-pipelines
Copy link

✔️ d6ccecd -> Azure artifacts URL

@github-actions
Copy link
Contributor

✔️ 2bbe75b -> artifacts URL

@azure-pipelines
Copy link

✔️ 2bbe75b -> Azure artifacts URL

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

✔️ 1f59aca -> artifacts URL

@github-actions
Copy link
Contributor

✔️ 7a98c1d -> artifacts URL

@azure-pipelines
Copy link

✔️ 7a98c1d -> Azure artifacts URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cython rxd reaction-diffusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants