Remove unused var OCSMALL and subsequently READLINE#3720
Open
alkino wants to merge 2 commits intoneuronsimulator:masterfrom
Open
Remove unused var OCSMALL and subsequently READLINE#3720alkino wants to merge 2 commits intoneuronsimulator:masterfrom
alkino wants to merge 2 commits intoneuronsimulator:masterfrom
Conversation
The first one is no more used or set. So the second one is always true.
alkino
commented
Feb 17, 2026
| #if OCSMALL | ||
| if (argc == 1) { | ||
| ocsmall_argv[0] = our_argv[0]; | ||
| exit_status = oc.run(2, ocsmall_argv); |
Member
Author
There was a problem hiding this comment.
This is the reason I want to remove this macro because this code looks unable to compile due to the variable oc that is defined in an other "macro-hierarchy".
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3720 +/- ##
=======================================
Coverage 68.30% 68.30%
=======================================
Files 689 689
Lines 111033 111033
=======================================
Hits 75844 75844
Misses 35189 35189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first one is no more used or set.
So the second one is always true.