Conversation
Add support for managing external binary processes as framework services with automatic lifecycle management and RPC-style communication. - Add getCurrentResourcePath() method to IResourceInfo interface and implementations - Create @BinaryService decorator to register external binaries as managed services - Create @binarycall decorator to mark methods as remote binary actions - Implement BinaryProcessManager for process lifecycle an
Enhance logging for rejected suspicious commands by including the player's accountID and command arguments in the warning log context for better debugging and security monitoring.
Add comprehensive logging throughout the binary process lifecycle including service registration, binary path resolution, action calls, process spawning, and response handling. Add error logging for timeouts and failed calls. Refactor binary path resolution to check multiple locations using a loop instead of sequential checks.
Expand JSDoc comments for @BinaryService and @binarycall decorators with detailed explanations of runtime behavior, RPC mechanism, and usage semantics. Add inline documentation for BinaryServiceOptions properties (name, binary, timeoutMs) clarifying their purpose and constraints.
Feat/binaries
- Remove "Scope" section from README - Remove `@open-core/framework/shared` and `@open-core/framework/utils` from documented exports - Update import example to use `/server` subpath - Move reflect-metadata, tsyringe, and zod to peerDependencies - Keep uuid as regular dependency
- Change "Website" link text to "Docs" in README header - Simplify Server.init example to use 'CORE' mode without features config - Remove Server.setAuthProvider from providers example - Update RELEASE.md version from v0.4.0 to v0.3.3 - Add peer dependencies note to v0.3.3 release highlights - Remove extra horizontal rules from release notes formatting - Clarify GLOBAL_CONTAINER usage with client/server context comment - Change GLOBAL_CONTAINER export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.