Skip to content

fix: Update measure API types#1694

Merged
metal-messiah merged 5 commits into
mainfrom
fix-measure-api-types
Feb 17, 2026
Merged

fix: Update measure API types#1694
metal-messiah merged 5 commits into
mainfrom
fix-measure-api-types

Conversation

@metal-messiah

@metal-messiah metal-messiah commented Feb 12, 2026

Copy link
Copy Markdown
Member

Corrects an issue where the typings associated with the measure API did not accept PerformanceMark as a valid input for start or end values.

Overview

Related Issue(s)

Fixes #1693
NR-523184

Testing

Updated the typings test to accurately reflect the code and public docs.

@github-actions

Copy link
Copy Markdown

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions

github-actions Bot commented Feb 12, 2026

Copy link
Copy Markdown

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 26.92 kB / 10.19 kB (gzip) 26.92 kB / 10.19 kB (gzip) 0% / 0% (gzip)
lite async-chunk 55.09 kB / 18.47 kB (gzip) 55.09 kB / 18.47 kB (gzip) 0% / 0% (gzip)
pro loader 61.58 kB / 21.62 kB (gzip) 61.58 kB / 21.62 kB (gzip) 0% / 0% (gzip)
pro async-chunk 91.54 kB / 28.99 kB (gzip) 91.54 kB / 28.99 kB (gzip) 0% / 0% (gzip)
spa loader 63.98 kB / 22.42 kB (gzip) 63.98 kB / 22.42 kB (gzip) 0% / 0% (gzip)
spa async-chunk 102.76 kB / 31.87 kB (gzip) 102.76 kB / 31.87 kB (gzip) 0% / 0% (gzip)

@codecov

codecov Bot commented Feb 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.25%. Comparing base (81bfd8f) to head (72938ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1694   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         210      210           
  Lines        7508     7508           
  Branches     1538     1538           
=======================================
  Hits         6626     6626           
  Misses        781      781           
  Partials      101      101           
Flag Coverage Δ
unit-tests 81.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ptang-nr

ptang-nr commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

A couple more files that would require an update:

  • src/loaders/api/register-api-types.js
  • src/interfaces/registered-entity.js

❔ Maybe consider refactoring to define the typedefs once and reference 'em everywhere else

@metal-messiah

Copy link
Copy Markdown
Member Author

A couple more files that would require an update:

  • src/loaders/api/register-api-types.js
  • src/interfaces/registered-entity.js

❔ Maybe consider refactoring to define the typedefs once and reference 'em everywhere else

There's some quirks here with the way the types are generated that the IDE doesn't end up picking up the commentary from the types when they are not directly on the method. Lets split that off into a new ticket

@metal-messiah metal-messiah merged commit dd2951b into main Feb 17, 2026
18 checks passed
@metal-messiah metal-messiah deleted the fix-measure-api-types branch February 17, 2026 22:06
metal-messiah added a commit that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type of measure method is missing PerformanceMark support.

3 participants