fix: Update measure API types#1694
Conversation
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
=======================================
Coverage 88.25% 88.25%
=======================================
Files 210 210
Lines 7508 7508
Branches 1538 1538
=======================================
Hits 6626 6626
Misses 781 781
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
A couple more files that would require an update:
❔ Maybe consider refactoring to define the typedefs once and reference 'em everywhere else |
There's some quirks here with the way the types are generated that the IDE doesn't end up picking up the commentary from the types when they are not directly on the method. Lets split that off into a new ticket |
Corrects an issue where the typings associated with the measure API did not accept PerformanceMark as a valid input for start or end values.
Overview
Related Issue(s)
Fixes #1693
NR-523184
Testing
Updated the typings test to accurately reflect the code and public docs.