Skip to content

fix: Circular replacer removed reused objects from harvests#1718

Merged
metal-messiah merged 2 commits into
mainfrom
circular-replacer
Mar 12, 2026
Merged

fix: Circular replacer removed reused objects from harvests#1718
metal-messiah merged 2 commits into
mainfrom
circular-replacer

Conversation

@metal-messiah

Copy link
Copy Markdown
Member

Fixed a bug where our internal stringify method would strip out shared pointers of objects across harvest payloads. This was resulting in occasionally missing params attributes on errors harvests.

Overview

Related Issue(s)

This was found as part of writing the AJAX and Errors logic for auto-MFE

Testing

Please see the new test case

@github-actions

Copy link
Copy Markdown

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions

Copy link
Copy Markdown

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 26.92 kB / 10.18 kB (gzip) 26.92 kB / 10.18 kB (gzip) 0% / 0% (gzip)
lite async-chunk 55.11 kB / 18.46 kB (gzip) 55.16 kB / 18.49 kB (gzip) 0.08% / 0.12% (gzip)
pro loader 62.53 kB / 21.95 kB (gzip) 62.57 kB / 21.96 kB (gzip) 0.07% / 0.04% (gzip)
pro async-chunk 91.55 kB / 28.98 kB (gzip) 91.55 kB / 28.98 kB (gzip) 0% / 0% (gzip)
spa loader 64.93 kB / 22.76 kB (gzip) 64.97 kB / 22.77 kB (gzip) 0.07% / 0.04% (gzip)
spa async-chunk 102.78 kB / 31.87 kB (gzip) 102.78 kB / 31.87 kB (gzip) 0% / 0% (gzip)

@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.75%. Comparing base (0dea41a) to head (75aa4d4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   88.74%   88.75%           
=======================================
  Files         210      210           
  Lines        7546     7552    +6     
  Branches     1550     1553    +3     
=======================================
+ Hits         6697     6703    +6     
  Misses        756      756           
  Partials       93       93           
Flag Coverage Δ
unit-tests 82.48% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/common/util/stringify.js

@ptang-nr ptang-nr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@cwli24 cwli24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double vetted that this works to remove circular refs but allow duplicative ref in different branches

@metal-messiah metal-messiah merged commit 76024d0 into main Mar 12, 2026
18 checks passed
@metal-messiah metal-messiah deleted the circular-replacer branch March 12, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants