fix: Circular replacer removed reused objects from harvests#1718
Conversation
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 88.74% 88.75%
=======================================
Files 210 210
Lines 7546 7552 +6
Branches 1550 1553 +3
=======================================
+ Hits 6697 6703 +6
Misses 756 756
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwli24
left a comment
There was a problem hiding this comment.
Double vetted that this works to remove circular refs but allow duplicative ref in different branches
Fixed a bug where our internal stringify method would strip out shared pointers of objects across harvest payloads. This was resulting in occasionally missing
paramsattributes on errors harvests.Overview
Related Issue(s)
This was found as part of writing the AJAX and Errors logic for auto-MFE
Testing
Please see the new test case