Skip to content

chore(dialogs)!: remove deprecated setHTML method #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Oct 1, 2025
Merged

chore(dialogs)!: remove deprecated setHTML method #1985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ For Vue 3 apps nothing changed, meaning the app and this library will share the
* This package now uses Vue 3 internally.
* The deprecated FilePicker component export was removed to allow using this library in Vue 2 and Vue 3 apps.
* The deprecated `Dialog.hide` method was removed, instead await the returned promise and wait for the user interaction.
* The deprecated `Dialog.setHTML` method was removed. If you need custom HTML content use `NcDialog` from `@nextcloud/vue`.
* The `spawnDialog` helper method was removed, instead use the function provided by `@nextcloud/vue`
```diff
- import { spawnDialog } from '@nextcloud/dialogs'
Expand Down
14 changes: 0 additions & 14 deletions lib/dialogs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ export class Dialog {
#buttons: IDialogButton[]
#severity?: IDialogSeverity

/** @deprecated */
#html?: string

constructor(
name: string,
text: string,
Expand All @@ -33,16 +30,6 @@ export class Dialog {
this.#text = text
this.#buttons = buttons
this.#severity = severity
this.#html = undefined
}

/**
* @deprecated DO NOT USE! It will be removed in the near future!
* @param html HTML content
*/
setHTML(html: string) {
this.#html = html
return this
}

/**
Expand All @@ -58,7 +45,6 @@ export class Dialog {
name: this.#name,
text: this.#text,
severity: this.#severity,
html: this.#html,
},
)
if (!result) {
Expand Down