feat(FilePicker): Improve pick and navigation logic to match user expectation#2033
Merged
feat(FilePicker): Improve pick and navigation logic to match user expectation#2033
Conversation
Merged
1 task
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
- Coverage 49.93% 49.32% -0.62%
==========================================
Files 22 22
Lines 803 813 +10
Branches 102 102
==========================================
Hits 401 401
- Misses 401 411 +10
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a0c341f to
543281c
Compare
susnux
reviewed
Oct 16, 2025
susnux
reviewed
Oct 16, 2025
susnux
approved these changes
Oct 16, 2025
Contributor
susnux
left a comment
There was a problem hiding this comment.
I would just insist on the CSS one, the other comment is just an idea.
Meaning otherwise its really nice!
543281c to
9303c0d
Compare
Signed-off-by: Louis Chmn <[email protected]>
e80123a to
896ce75
Compare
This will inhibit selection of nodes Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
896ce75 to
9895f85
Compare
canPick option to gray out nodes2b6e341 to
99fd682
Compare
19437c4 to
d3bbe36
Compare
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
896732a to
c6dd72c
Compare
susnux
approved these changes
Oct 19, 2025
Contributor
Author
|
/backport to stable6 |
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canPickoption