Skip to content

fix: Don't apply password policy when trying to confirm a password#1228

Merged
nickvergessen merged 1 commit intomainfrom
bugfix/noid/dont-apply-password-policy-on-confirming
Nov 12, 2025
Merged

fix: Don't apply password policy when trying to confirm a password#1228
nickvergessen merged 1 commit intomainfrom
bugfix/noid/dont-apply-password-policy-on-confirming

Conversation

@nickvergessen
Copy link
Contributor

  1. Set up an account with a "6 character password"
  2. Enable password policy (default 10 chars)
  3. Perform an admin action
  4. 🛑 you can not confirm as your password is too short.
Bildschirmfoto vom 2025-11-12 11-55-24

This check is only required for "new" passwords

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Nov 12, 2025
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews labels Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (da1c13b) to head (0610d9f).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1228   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           20        20           
  Branches         3         3           
=========================================
  Hits            20        20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy
Copy link

had to pack it in server/build/frontend-legacy to test...

Not blocking anymore, but password error is briefly seen, might be coming from a vue component
2025-11-12_13h02_19

@nickvergessen nickvergessen merged commit af2ca2f into main Nov 12, 2025
12 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/dont-apply-password-policy-on-confirming branch November 12, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants