feat(UploadPicker): Allow to set color to primary#1606
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Pytal
left a comment
There was a problem hiding this comment.
Could also work with a buttonType prop and pass it as is?
IMHO to many options as there is no sense in making it error or warning state. |
|
I think I agree with Pytal, even if there is no reason for now, it also lowers the complexity by making it transparent what we are doing under the hood. |
Not sure as then some will use weird combinations which do not want. We want consistent design across all apps so we should limit what dev can do here to sane options. |
I don't think I agree here, and in any case, devs can still bypass the property by overriding the CSS. |
|
I do get both side, and i'll raise another reason to go this way: if the vue button API changes, we suddenly have to also update this API here.
If a dev decide to go this way, they'll already lost. |
Required for nextcloud/server#48527