fix: use correct path for watch parameter#686
fix: use correct path for watch parameter#686Chartman123 wants to merge 1 commit intonextcloud-libraries:mainfrom
Conversation
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
susnux
added
type: bug
|
/backport to stable1 |
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Both paths seem correct
https://rollupjs.org/configuration-options/#watch-allowinputinsideoutputpath
Probably Vite overrides the one from rollupOptions?
Thats also my guess |
|
It seems it then always tries to use watch mode even if |
|
Oh ok, I didn't test that, just tried if the watch parameter works again |
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
See vitejs/vite#20657 (comment)
We need to either detect this with the suggested work around or investigate why rollupOptions are not working here - as locally it works (without this library).
|
This is a vite bug: vitejs/vite#20674 |
Ok, so we can close this one and wait for the upstream fix? |
|
Will be fixed with #693 |
3 participants
This replaces a PR for Forms (nextcloud/forms#2872) that fixes nextcloud/forms#2869
In #666 the rollup config was adjusted but used a wrong path for the introduced parameter.