fix(ncselect): Fix styling if a custom theme is applied#3707
Merged
Conversation
susnux
added
bug
Pytal
approved these changes
Feb 1, 2023
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
fix/ncselect-theming
branch
from
1492527 to
fec54a2
Compare
JuliaKirschenheuter
approved these changes
Feb 9, 2023
Contributor
JuliaKirschenheuter
left a comment
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
I would confirm, but @skjnldsv are you agree too?
Pytal
added
4. to release
Contributor
Probably AFK ⌨ |
6 tasks
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can not set variables referencing themeable variables on the
:rootas currently the theme variables are applied on thebodyelement. Meaningvar()will be evaluated with the context of the:rootelement, which does not apply the user selected theme.We neither can set this variables on the
select, because the some of the variables are used to style the dropdown list which is a modal so not a child of the select.This fixes issues like this:
nextcloud/forms#1471 (review)
See also nextcloud/server#36462