Merge @nextcloud/vue-richtext into @nextcloud/vue#3841
Conversation
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
d93daf2 to
9d82207
Compare
There was a problem hiding this comment.
Wow that was fast! Thank you very much. ❤️
I tried it with the latest spreed master. The link picker in NcRichContenteditable works like a charm.
We need to expose the searchProvider function (in src/components/NcRichText/NcReferencePicker/providerHelper.js) because it is used in Text (which has its own implementation using Tribute).
It is exposed in src/components/NcRichText/index.js.
I'll make some more tests with Text soon.
This comment was marked as resolved.
This comment was marked as resolved.
|
Ok, test results are all green: Spreed
Text
All good from my pov. ✔️ ❤️ I'll prepare the PRs to bring this in spreed and text to the next Vue lib release. |
This comment was marked as resolved.
This comment was marked as resolved.
Great to hear! Thanks a lot for checking. |
@nextcloud/vue-richtext into @nextcloud/vue
julien-nc
left a comment
There was a problem hiding this comment.
Successfully tested in spreed and text
- link picker stuff ✔️
- reference widget stuff ✔️
- NcRichText ✔️
Signed-off-by: Raimund Schlüßler <[email protected]>
|
Let me also add the |
Signed-off-by: Raimund Schlüßler <[email protected]>
mejo-
left a comment
There was a problem hiding this comment.
Code looks good to me 👌
I didn't test myself, but apparently @julien-nc did so
Great to get @nextcloud/vue-richtext incorporated into @nextcloud/vue
|
Tested now as well with Text and works like a charm 🎉 |
This PR merges @nextcloud/vue-richtext into the repository here. I mainly copied the code from
vue-richtext, adjusted the import paths, fixed lint errors and removed the dependency tovue-richtext.The
NcRichTextexample in the docs seems to work fine: https://deploy-preview-3841--nextcloud-vue-components.netlify.app/#/Components/NcRichText?id=ncrichtext-1But a deeper check is still necessary, since I don't know the internal of
vue-richtextand which exports are necessary. We also need to figure out how to handle therichtext.scssfile.Anyway, it would be best if you could check whether
@nextcloud/vuemore or less works as a drop-in-replacement for@nextcloud/vue-richtextnow.I still have to fix the jsdoc lint warnings, though.
Closes #3812.