enh(NcCheckboxRadioSwitch): Allow to set aria-label#4903
Merged
Conversation
…text is shown Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
enhancement
Contributor
Author
|
Alternative would be disable forwarding attr and filter for any |
ShGKme
approved these changes
Dec 1, 2023
Contributor
Forwarding attrs (without filtering) may make sense as this component is (sometimes) an But we already have a long list of |
Closed
4 tasks
Pytal
approved these changes
Dec 1, 2023
Pytal
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
If no text should be shown currently you have to provide the label as a
spanwithhidden-visually, because thearia-labelwould not be forwarded correctly.🏁 Checklist