fix(NcListItem): Ensure list item does not overflow wrapper#4956
Merged
fix(NcListItem): Ensure list item does not overflow wrapper#4956
Conversation
…dth 100% and padding Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
bug
susnux
requested review from
Pytal,
ShGKme,
marcoambrosini and
raimund-schluessler
ShGKme
approved these changes
Dec 13, 2023
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
I wonder if we can just make box-sizing: border-box; a global default...
2 tasks
Pytal
approved these changes
Dec 14, 2023
Pytal
added
4. to release
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
widthis set to 100% but ifbox-sizingis not set toborder-boxit will not include the border and the padding.This causes the list item to overflow its parents in some cases, you can for example see this in the new unified search of Nextcloud 28 (there are even more places).
To fix this simply set
box-sizingtoborder-boxof the list item.🖼️ Screenshots
🏁 Checklist