enh(aria): changed check color to adhere to 3:1 ratio#4958
Merged
Conversation
emoral435
requested review from
JuliaKirschenheuter,
Pytal,
ShGKme and
nfebe
emoral435
added
3. to review
Contributor
Author
|
For context - the choice between black and white was a heuristic, and I checked, all the buttons pass the 3:1 ratio, if not higher! |
Contributor
|
Nice! But please fix the linting issues. |
emoral435
force-pushed
the
enh/make-contrast-clear-ARIA-CHANGE
branch
from
150a38b to
be16c8a
Compare
Contributor
Author
|
Fixed linting error : ) |
ShGKme
reviewed
Dec 14, 2023
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435
force-pushed
the
enh/make-contrast-clear-ARIA-CHANGE
branch
from
be16c8a to
938b6a2
Compare
susnux
approved these changes
Dec 15, 2023
Pytal
approved these changes
Dec 15, 2023
ShGKme
added
bug
Contributor
|
Remember to add |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves nextcloud/server#41861
🖼️ Screenshots
🚧 Summary
Changes the check color depending on the background color chosen to either be white or black to achieve the 3:1 contrast ratio for ARIA - radio input button still has white border, so up to reviewers to decide if that should change
🏁 Checklist