fix(NcActions): In case of inline actions make sure to support icon as URL#5053
Merged
fix(NcActions): In case of inline actions make sure to support icon as URL#5053
Conversation
susnux
added
bug
susnux
force-pushed
the
fix/make-nc-actions-support-icon-url
branch
from
e70fd33 to
837fe3c
Compare
Pytal
reviewed
Jan 10, 2024
Pytal
approved these changes
Jan 10, 2024
ShGKme
approved these changes
Jan 10, 2024
…s URL Added an unit test case. Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com> Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/make-nc-actions-support-icon-url
branch
from
c0ee984 to
95fe5dc
Compare
ShGKme
approved these changes
Jan 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The actions support the
iconprop with class and URL, but if they are rendered as inline actions the URL was not used currently as the icon but set as class.🖼️ Screenshots
🏁 Checklist