feat(NcAssistant*): provide components for consistent integrations design#7398
Merged
AndyScherzinger merged 1 commit intomainfrom Aug 29, 2025
Merged
feat(NcAssistant*): provide components for consistent integrations design#7398AndyScherzinger merged 1 commit intomainfrom
AndyScherzinger merged 1 commit intomainfrom
Conversation
susnux
added
enhancement
susnux
force-pushed
the
feat/NcAssistant
branch
from
c6f8268 to
4fe86b8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
reviewed
Aug 27, 2025
Contributor
On the screenshot in the PR description, the icon position looks a bit not aligned with anything, not centered. Is it an intentional position? |
Contributor
Author
Its just for showcasing the content wrapper (as that border is a bit more complex to create and thus a very simple container can help). I did not put too much into the styling 😅 |
Contributor
|
I missed that this icon is not a part of the |
ShGKme
reviewed
Aug 27, 2025
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
approved these changes
Aug 28, 2025
AndyScherzinger
approved these changes
Aug 28, 2025
jancborchardt
approved these changes
Aug 28, 2025
… design * see also nextcloud/server#54679 - also use proper BEM for modules, see https://en.bem.info/methodology/naming-convention/#camelcase-style Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/NcAssistant
branch
from
a57821a to
3784f2b
Compare
Contributor
|
/backport to stable8 |
2 tasks
Antreesy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable