Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 4, 2025

☑️ Resolves

  • A minor bug
  • The gap is 16px
  • In the design it was the gap between the text baseline and the content
  • In the implementation it is a gap between the text block (including lint-height) and the content

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme self-assigned this Nov 4, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.57%. Comparing base (06e167c) to head (a5dce77).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7775   +/-   ##
=======================================
  Coverage   51.57%   51.57%           
=======================================
  Files          96       96           
  Lines        3143     3143           
  Branches      863      864    +1     
=======================================
  Hits         1621     1621           
  Misses       1274     1274           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme force-pushed the fix/NcFormGroup--margin-size branch from 5281768 to a5dce77 Compare November 5, 2025 13:04
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 5, 2025

  • Resolved the conflict

@ShGKme ShGKme merged commit 048a4db into main Nov 5, 2025
27 checks passed
@ShGKme ShGKme deleted the fix/NcFormGroup--margin-size branch November 5, 2025 13:13
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 5, 2025

/backport to stable8

@backportbot
Copy link

backportbot bot commented Nov 5, 2025

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/7775/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a5dce77f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7775/stable8

Error: Failed to check for changes with origin/stable8: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 5, 2025

/backport to stable8

@backportbot
Copy link

backportbot bot commented Nov 5, 2025

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/7775/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a5dce77f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7775/stable8

Error: Failed to check for changes with origin/stable8: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants