Skip to content

feat: NcAppSettingsSectionShortcuts -> NcAppSettingsShortcutsSection#7814

Merged
ShGKme merged 1 commit intomainfrom
feat/rename-NcAppSettingsSectionShurtcuts-to-NcAppSettingsShortcutsSection
Nov 7, 2025
Merged

feat: NcAppSettingsSectionShortcuts -> NcAppSettingsShortcutsSection#7814
ShGKme merged 1 commit intomainfrom
feat/rename-NcAppSettingsSectionShurtcuts-to-NcAppSettingsShortcutsSection

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 7, 2025

☑️ Resolves

  • Because the new component is a specific version of the common component, but not the part/child of it, it should be named Section + ShortcutsSection, not Section + SectionShortcuts
  • The component is also re-exported by the old name with deprecation to prevent breaking changes

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added this to the 9.2.0 milestone Nov 7, 2025
@ShGKme ShGKme self-assigned this Nov 7, 2025
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews labels Nov 7, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 7, 2025

/backport to stable8

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.58%. Comparing base (2ec172e) to head (e506d0e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7814   +/-   ##
=======================================
  Coverage   51.58%   51.58%           
=======================================
  Files          96       96           
  Lines        3148     3148           
  Branches      865      865           
=======================================
  Hits         1624     1624           
  Misses       1276     1276           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component is also re-exported by the old name with deprecation to prevent breaking changes

Did we introduce them already?

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 7, 2025

Did we introduce them already?

Yep, in 9.1.0. You even drafted a PR with them in Talk :P

@ShGKme ShGKme merged commit 58175c1 into main Nov 7, 2025
27 checks passed
@ShGKme ShGKme deleted the feat/rename-NcAppSettingsSectionShurtcuts-to-NcAppSettingsShortcutsSection branch November 7, 2025 14:09
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 7, 2025

/backport to stable8

@backportbot
Copy link

backportbot bot commented Nov 7, 2025

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/7814/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e506d0e9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7814/stable8

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud-libraries:backport/7814/stable8."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@ShGKme ShGKme mentioned this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants