Skip to content

fix(NcActions): introduce 'size' prop#7847

Merged
Antreesy merged 1 commit intomainfrom
feat/noid/ncactions-prop-size
Nov 13, 2025
Merged

fix(NcActions): introduce 'size' prop#7847
Antreesy merged 1 commit intomainfrom
feat/noid/ncactions-prop-size

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

  • Allows to pass 'size' prop to underlying NcButton components
  • Introducing beforehand, if that would be ever required by apps

🖼️ Screenshots

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added this to the 9.3.0 milestone Nov 12, 2025
@Antreesy Antreesy self-assigned this Nov 12, 2025
@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews feature: actions Related to the actions components labels Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.75%. Comparing base (dd4ff45) to head (872c49a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7847      +/-   ##
==========================================
+ Coverage   51.72%   51.75%   +0.03%     
==========================================
  Files          98       98              
  Lines        3167     3169       +2     
  Branches      872      872              
==========================================
+ Hits         1638     1640       +2     
  Misses       1279     1279              
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme
Copy link
Contributor

ShGKme commented Nov 12, 2025

/backport to stable8

@Antreesy Antreesy force-pushed the feat/noid/ncactions-prop-size branch from 49cc84c to 2c5dff7 Compare November 12, 2025 17:37
@Antreesy Antreesy force-pushed the feat/noid/ncactions-prop-size branch from 2c5dff7 to 872c49a Compare November 13, 2025 08:21
@Antreesy Antreesy enabled auto-merge November 13, 2025 08:21
@Antreesy Antreesy merged commit eac1b94 into main Nov 13, 2025
27 checks passed
@Antreesy Antreesy deleted the feat/noid/ncactions-prop-size branch November 13, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: actions Related to the actions components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants