Skip to content

docs: Move more icons to outline#7862

Merged
nickvergessen merged 1 commit intomainfrom
docs/noid/move-to-outline-icons-2
Nov 14, 2025
Merged

docs: Move more icons to outline#7862
nickvergessen merged 1 commit intomainfrom
docs/noid/move-to-outline-icons-2

Conversation

@nickvergessen
Copy link
Contributor

🖼️ Screenshots

🏚️ Before 🏡 After
Bildschirmfoto vom 2025-11-14 14-23-54 Bildschirmfoto vom 2025-11-14 14-23-45
Bildschirmfoto vom 2025-11-14 14-25-04 Bildschirmfoto vom 2025-11-14 14-25-48
Bildschirmfoto vom 2025-11-14 14-29-36 Bildschirmfoto vom 2025-11-14 14-29-26
Bildschirmfoto vom 2025-11-14 14-31-00 Bildschirmfoto vom 2025-11-14 14-31-49
Bildschirmfoto vom 2025-11-14 14-32-22 Bildschirmfoto vom 2025-11-14 14-32-54
Bildschirmfoto vom 2025-11-14 14-34-38 Bildschirmfoto vom 2025-11-14 14-37-02
Bildschirmfoto vom 2025-11-14 14-38-25 Bildschirmfoto vom 2025-11-14 14-38-33
Bildschirmfoto vom 2025-11-14 14-40-13 Bildschirmfoto vom 2025-11-14 14-40-25
Bildschirmfoto vom 2025-11-14 14-45-15 Bildschirmfoto vom 2025-11-14 14-47-45
Bildschirmfoto vom 2025-11-14 14-48-30 Bildschirmfoto vom 2025-11-14 14-49-57

Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.78%. Comparing base (8f99087) to head (e5c85b3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7862   +/-   ##
=======================================
  Coverage   51.78%   51.78%           
=======================================
  Files          98       98           
  Lines        3171     3171           
  Branches      874      874           
=======================================
  Hits         1642     1642           
  Misses       1279     1279           
  Partials      250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickvergessen nickvergessen requested review from Antreesy and DorraJaouad and removed request for Antreesy November 14, 2025 14:22
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: documentation Related to the documentation labels Nov 14, 2025
@nickvergessen nickvergessen self-assigned this Nov 14, 2025
@nickvergessen nickvergessen added this to the 9.2.0 milestone Nov 14, 2025
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💙

@ShGKme
Copy link
Contributor

ShGKme commented Nov 14, 2025

Arr, double-clicking mouse

@ShGKme ShGKme modified the milestones: 9.2.0, 9.3.0 Nov 14, 2025
@ShGKme ShGKme removed the bug Something isn't working label Nov 14, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Nov 14, 2025

/backport to stable8

@susnux
Copy link
Contributor

susnux commented Nov 14, 2025

/backport to stable8

what is the current position on backporting this even though this will change how legacy NC versions will look like in next maintenance releases?

@ShGKme
Copy link
Contributor

ShGKme commented Nov 14, 2025

what is the current position on backporting this even though this will change how legacy NC versions will look like in next maintenance releases?

I didn't get what you mean. It's documentation, what does it change in Nextcloud versions?

@ShGKme
Copy link
Contributor

ShGKme commented Nov 14, 2025

@nextcloud/vue v9 is also used in Nextcloud versions with the filled icons.

@nickvergessen nickvergessen merged commit 4da594b into main Nov 14, 2025
27 checks passed
@nickvergessen nickvergessen deleted the docs/noid/move-to-outline-icons-2 branch November 14, 2025 20:00
@susnux
Copy link
Contributor

susnux commented Nov 14, 2025

@nextcloud/vue v9 is also used in Nextcloud versions with the filled icons.

Well but in general v9 is mostly used by newer Nextcloud versions (is there an official app that is Vue 3 on Nextcloud 31?).
But what I mean is that v8 will change Nextcloud core down to basically every version if there is a problem we need to fix and always down to v31.

Basically my concerns are not about apps but Nextcloud core.

@ShGKme
Copy link
Contributor

ShGKme commented Nov 14, 2025

@susnux How are these concerns related to this PR with the documentation update?

Or they are unrelated to the PR and in general about icon design update?

@susnux
Copy link
Contributor

susnux commented Nov 17, 2025

Or they are unrelated to the PR and in general about icon design update?

Unrelated to this PR its more about:
Why do we handle legacy design like in buttons but the most visual change for users are the icons that now would change for stable branches. And a more follow up question to: Should be also have icon legacy handling.

Not necessary in examples but in the real components.

@ShGKme
Copy link
Contributor

ShGKme commented Nov 23, 2025

Why do we handle legacy design like in buttons but the most visual change for users are the icons that now would change for stable branches. And a more follow up question to: Should be also have icon legacy handling.

So you wanted to have isLegacy switch for the icons in components like for the classes/styles, correct? Or is it a hint at the corresponding RFC in standards? 😶

IMO, it is much a less visual change than others:

  • It is not a layout change like going from 44px to 34px
  • It is not a single thing used everywhere like 1px vs 2px border on EVERY interactive element
  • In the past we often had a mix, so even solid icons were not really consistent

@susnux
Copy link
Contributor

susnux commented Nov 24, 2025

So you wanted to have isLegacy switch for the icons in components like for the classes/styles, correct? Or is it a hint at the corresponding RFC in standards? 😶

Both ;)
Bur for the first its more a question if we can live with inconsistent Nextcloud UIs in stable versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: documentation Related to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants