fix(NcAvatar): do no request avatar image if icon slot provided#7891
Merged
fix(NcAvatar): do no request avatar image if icon slot provided#7891
Conversation
Antreesy
added
bug
Contributor
Most of the changes are not related to the PR title (release note) 👀 |
ShGKme
approved these changes
Nov 19, 2025
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Please, the next time split into 2 PRs for 2 independent changes, or do not forget to manually adjust the changelog
DorraJaouad
approved these changes
Nov 19, 2025
Antreesy
force-pushed
the
fix/noid/nc-avatar
branch
from
bfd903c to
8d744f9
Compare
Contributor
Author
|
/backport to stable8 |
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
ShGKme
force-pushed
the
fix/noid/nc-avatar
branch
from
8d744f9 to
121badd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7891 +/- ##
==========================================
+ Coverage 52.11% 52.14% +0.03%
==========================================
Files 100 100
Lines 3170 3170
Branches 872 871 -1
==========================================
+ Hits 1652 1653 +1
Misses 1271 1271
+ Partials 247 246 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
<slot #icon>is provided by app and therefore won't be ever shown🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable