Conversation
Contributor
Author
|
/backport to stable8 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8037 +/- ##
=======================================
Coverage 53.25% 53.25%
=======================================
Files 101 101
Lines 3145 3145
Branches 872 872
=======================================
Hits 1675 1675
Misses 1232 1232
Partials 238 238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Antreesy
approved these changes
Dec 23, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Rest changes seem to not change the behaviour; tested, works now for missing translations
ShGKme
reviewed
Dec 23, 2025
ShGKme
approved these changes
Dec 23, 2025
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Bu I'd remove debug comment generation.
When a vue file is handled by vite it will have some query string like `source.vue?lang=ts&...` so to properly add the correct translations for that file we need to remove the query string. This resolves an issue where some files (e.g. `NcAppSettingsShortcutsSection`) were missing their translations in the bundle. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
Done. No other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
When a vue file is handled by vite it will have some query string like
source.vue?lang=ts&...so to properly add the correct translations for that file we need to remove the query string.This resolves an issue where some files (e.g.
NcAppSettingsShortcutsSection) were missing their translations in the bundle.🏁 Checklist
stable8for maintained Vue 2 version or not applicable