fix(NcModal): Adjust max height to leave some space#8042
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8042 +/- ##
=======================================
Coverage 53.25% 53.25%
=======================================
Files 101 101
Lines 3145 3145
Branches 872 872
=======================================
Hits 1675 1675
Misses 1232 1232
Partials 238 238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/backport to stable8 |
jancborchardt
approved these changes
Dec 30, 2025
Contributor
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Nice, much better! :)
Antreesy
approved these changes
Dec 30, 2025
ShGKme
requested changes
Dec 30, 2025
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
It looks like the added value is actually defined by body margin rather than some empirical padding.
This is so that the modal doesn't exactly touch the edges of the header, which looks a bit weird. Signed-off-by: Laura Kramolis <git@kramo.page> Signed-off-by: kramo <git@kramo.page>
kra-mo
force-pushed
the
fix/modal-max-height-adjustment
branch
from
ae360a8 to
bbb8623
Compare
ShGKme
approved these changes
Dec 30, 2025
github-project-automation
bot
moved this from 🏗️ At engineering
to 🎉 Done
in 🖍 Design team
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so that the modal doesn't exactly touch the edges of the header, which looks a bit weird. Sort of a follow-up to 4d9e81d.
Discussed with @jancborchardt and @nimishavijay
Not sure about backports?
🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable