Skip to content

[stable8] perf(NcTimezonePicker): use Intl to reduce self-size from 206kb to 2kb#8076

Merged
susnux merged 2 commits intostable8from
backport/7522/stable8
Jan 20, 2026
Merged

[stable8] perf(NcTimezonePicker): use Intl to reduce self-size from 206kb to 2kb#8076
susnux merged 2 commits intostable8from
backport/7522/stable8

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 12, 2026

@ShGKme ShGKme added this to the 8.36.0 milestone Jan 12, 2026
@ShGKme ShGKme requested review from Antreesy and susnux January 12, 2026 14:04
@ShGKme ShGKme self-assigned this Jan 12, 2026
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Jan 12, 2026
@ShGKme ShGKme force-pushed the backport/7522/stable8 branch from 39f765b to dc19d90 Compare January 12, 2026 20:22
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.02%. Comparing base (daa4b70) to head (9ade043).
⚠️ Report is 3 commits behind head on stable8.

Files with missing lines Patch % Lines
src/components/NcTimezonePicker/timezoneUtils.ts 0.00% 5 Missing ⚠️
...c/components/NcTimezonePicker/NcTimezonePicker.vue 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #8076      +/-   ##
===========================================
+ Coverage    45.99%   46.02%   +0.03%     
===========================================
  Files          192      192              
  Lines         4770     4760      -10     
  Branches      1168     1165       -3     
===========================================
- Hits          2194     2191       -3     
+ Misses        2490     2483       -7     
  Partials        86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme force-pushed the backport/7522/stable8 branch from dc19d90 to 363da52 Compare January 19, 2026 20:50
@ShGKme ShGKme marked this pull request as ready for review January 19, 2026 20:50
@ShGKme ShGKme marked this pull request as draft January 19, 2026 20:52
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the backport/7522/stable8 branch from 363da52 to 9ade043 Compare January 19, 2026 20:53
@ShGKme ShGKme marked this pull request as ready for review January 19, 2026 20:59
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good

@susnux susnux merged commit d285867 into stable8 Jan 20, 2026
20 of 23 checks passed
@susnux susnux deleted the backport/7522/stable8 branch January 20, 2026 09:55
@Antreesy Antreesy mentioned this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants