Setup rust build dependencies for rust projects#122
Draft
icewind1991 wants to merge 1 commit intomasterfrom
Draft
Setup rust build dependencies for rust projects#122icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
icewind1991
force-pushed
the
icewind1991-patch-1
branch
from
bf5c9ef to
6e00e47
Compare
Member
|
My usual remark: if this repo serves templates and this toolchain is only used for one app, wouldn't it make more sense if you add those steps just to that app? |
susnux
force-pushed
the
icewind1991-patch-1
branch
from
6e00e47 to
88f6b7b
Compare
Setup the rust toolchain when a Cargo.toml is detected Signed-off-by: Robin Appelman <robin@icewind.nl>
AndyScherzinger
force-pushed
the
icewind1991-patch-1
branch
from
88f6b7b to
538f45c
Compare
Member
Author
|
#46 would make this unneeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup the rust toolchain and friends when a Cargo.toml is detected
Might not make sense to have this in the general action with only one app needing it atm, but it would at least prevent someone from accidentally breaking the notify_push job when updating it and not noticing the changes made there.