Repository navigation
feat: request GPUs as CDI devices on Podman engines - #164
Open
oleksandr-nc wants to merge 1 commit into
Open
oleksandr-nc wants to merge 1 commit into
oleksandr-nc wants to merge 1 commit into
Conversation
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podman ignores the
nvidiadriver in a container's device requests, so ExApps on a CUDA daemon get no GPU when HaRP runs on a Podman engine. AppAPI's Docker Socket Proxy path asked Podman for the GPUs as CDI devices, and nextcloud/app_api#1209 removes that path, so HaRP has to do it.Changes
cudaExApp is created with the CDI devicenvidia.com/gpu=all, and without AppAPI'sNVIDIA_VISIBLE_DEVICESandNVIDIA_DRIVER_CAPABILITIESvariables, which are meant for the NVIDIA runtime hook. HaRP reads the Podman version from theLibpod-Api-Versionheader of the volume request it already sends, so there is no extra request.nvidia-ctk cdi generate --output=/etc/cdi/nvidia.yaml); without it the container of a CUDA ExApp no longer starts, while before it started without a GPU. The README says so.