fix: Use strict PHP comparaison #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Schwan <[email protected]>
provokateurin
approved these changes
Jan 22, 2026
julien-nc
approved these changes
Jan 22, 2026
CarlSchwan
added a commit
to nextcloud/server
that referenced
this pull request
Jan 26, 2026
Currently, it is documented in some places as returning a string but returns a int or a string depending on the database used. This then breaks then using strict comparaison in nextcloud/approval#362 Signed-off-by: Carl Schwan <[email protected]>
6 tasks
Before this would depends on the database backend and would break by mistake on Oracle when using strict type comparaison. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
added a commit
to nextcloud/server
that referenced
this pull request
Jan 26, 2026
Currently, it is documented in some places as returning a string but returns a int or a string depending on the database used. This then breaks then using strict comparaison in nextcloud/approval#362 Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
added a commit
to nextcloud/server
that referenced
this pull request
Jan 26, 2026
Currently, it is documented in some places as returning a string but returns a int or a string depending on the database used. This then breaks then using strict comparaison in nextcloud/approval#362 Signed-off-by: Carl Schwan <[email protected]>
kesselb
added a commit
that referenced
this pull request
Feb 6, 2026
The backend returns the tags a string since #362. NcSelectTags keeps them as integers. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
added a commit
that referenced
this pull request
Feb 6, 2026
The tags from TagAssignedEvent are ints, while tagPending is a string since #362. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
added a commit
that referenced
this pull request
Feb 6, 2026
The backend returns the tags a string since #362. NcSelectTags keeps them as integers. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
added a commit
that referenced
this pull request
Feb 6, 2026
The tags from TagAssignedEvent are ints, while tagPending is a string since #362. Signed-off-by: Daniel Kesselberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.