Bump node and npm version in package.json#3223
Merged
ChristophWurst merged 1 commit intomasterfrom Jun 16, 2021
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Codecov Report
@@ Coverage Diff @@
## master #3223 +/- ##
=========================================
Coverage 28.86% 28.86%
Complexity 121 121
=========================================
Files 157 157
Lines 5731 5731
Branches 841 841
=========================================
Hits 1654 1654
Misses 4077 4077
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
47 tasks
ChristophWurst
approved these changes
Jun 16, 2021
Member
|
@ChristophWurst #3215 was not merged yet, so package-lock.json is still at version 1. I guess this will lead to problem now that npm is required to be v7 with this PR. Surprisingly (to me at least), the build still passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com