Skip to content

Psalm failing due to API changes in master #1132

@nickvergessen

Description

@nickvergessen

#1131

ERROR: InvalidReturnType - lib/Db/DeprecatedCirclesRequestBuilder.php:198:13 - The declared return type 'OCP\DB\QueryBuilder\IQueryFunction' for OCA\Circles\Db\DeprecatedCirclesRequestBuilder::generateLimitClosed is incorrect, got 'null|string' (see https://psalm.dev/011)
	 * @return IQueryFunction


ERROR: InvalidReturnStatement - lib/Db/DeprecatedCirclesRequestBuilder.php:205:10 - The inferred type 'string' does not match the declared return type 'OCP\DB\QueryBuilder\IQueryFunction' for OCA\Circles\Db\DeprecatedCirclesRequestBuilder::generateLimitClosed (see https://psalm.dev/128)
		return $qb->expr()
                                  ->eq(
                                          'c.type',
                                          $qb->createNamedParameter(DeprecatedCircle::CIRCLES_CLOSED)
                                  );


ERROR: InvalidReturnType - lib/Db/DeprecatedCirclesRequestBuilder.php:217:13 - The declared return type 'OCP\DB\QueryBuilder\IQueryFunction' for OCA\Circles\Db\DeprecatedCirclesRequestBuilder::generateLimitPublic is incorrect, got 'null|string' (see https://psalm.dev/011)
	 * @return IQueryFunction


ERROR: InvalidReturnStatement - lib/Db/DeprecatedCirclesRequestBuilder.php:224:10 - The inferred type 'string' does not match the declared return type 'OCP\DB\QueryBuilder\IQueryFunction' for OCA\Circles\Db\DeprecatedCirclesRequestBuilder::generateLimitPublic (see https://psalm.dev/128)
		return $qb->expr()
                                  ->eq(
                                          'c.type',
                                          $qb->createNamedParameter(DeprecatedCircle::CIRCLES_PUBLIC)
                                  );


ERROR: UndefinedClass - lib/Model/ShareWrapper.php:407:12 - Class, interface or enum named OCP\Server does not exist (see https://psalm.dev/019)
			$l10n = \OCP\Server::get(IFactory::class)->get('circles');


------------------------------
5 errors found

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions