fix: fallback for empty file paths in Source construction#172
Merged
Conversation
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds fallback handling for empty file paths when constructing Source objects. The change ensures that if getInternalPath() returns empty or null, the code will fall back to getPath() and then to getName() as alternatives.
- Updates Source construction to use a fallback chain for file paths
- Applies the same pattern consistently across ScanService and IndexerJob
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/Service/ScanService.php | Added fallback chain for file path in Source construction |
| lib/BackgroundJobs/IndexerJob.php | Added fallback chain for file path in Source construction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marcelklehr
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.