feat: refactor settings to new design#7366
Merged
juliusknorr merged 1 commit intomainfrom Nov 19, 2025
Merged
Conversation
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
luka-nextcloud
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Office team
ShGKme
reviewed
Nov 13, 2025
luka-nextcloud
force-pushed
the
reorganize-settings
branch
from
c943e60 to
ad75661
Compare
grnd-alt
approved these changes
Nov 14, 2025
Member
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
two comments about the same variable.
I know it's the same variable usage as in AppNavigation before, but I do think we can just get rid of it, please double check that though.
Otherwise good🔥
ShGKme
reviewed
Nov 14, 2025
src/components/DeckAppSettings.vue
Outdated
Comment on lines
61
to
63
| <p class="app-settings-section__version"> | ||
| {{ t('deck', 'Deck version: {version}', { version: deckVersion }) }} | ||
| </p> |
There was a problem hiding this comment.
This part doesn't need to be added manually — it will be rendered automatically in the next nextcloud-vue release (already implemented and merged).
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
reorganize-settings
branch
from
ad75661 to
a32bdc0
Compare
ShGKme
approved these changes
Nov 19, 2025
Member
|
/backport to stable32 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist