fix: stop ignoring certain share rows

[salmart-dev]

• Target version: master

Summary

This PR:

• fixes the ON condition for the join
• moves join conditions to the ON clause
• removes an issue where if a user was missing the TYPE_DECK_USER row, the whole share would be missing
• changes the LIKE query to contain a / to reduce confusion

Will need a backport to the version for NC33

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required

[artonge]

Do we need to change that request too:

deck/lib/Sharing/DeckShareProvider.php

Lines 645 to 653 in 04904ff

	$query = $qb->select('*')
	->from('share')
	->where($qb->expr()->in('parent', $qb->createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)))
	->andWhere($qb->expr()->eq('share_with', $qb->createNamedParameter($userId)))
	->andWhere($qb->expr()->orX(
	$qb->expr()->eq('item_type', $qb->createNamedParameter('file')),
	$qb->expr()->eq('item_type', $qb->createNamedParameter('folder'))
	));

I think not as this is already filtering by parent.