Set default maxChunkSize to 1000MB #3314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: szaimen <szaimen@e.mail.de>
|
AppImage file: Nextcloud-PR-3314-653da8d570916903fa1e37a5099b61564a677068-x86_64.AppImage |
jospoortvliet
requested review from
camilasan and
mgallien
and removed request for
mgallien
mgallien
approved these changes
Jul 13, 2021
Collaborator
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
I believe that should be fine but what is the reason to do that ?
Can you clarify the reason in the commit message ?
This will not solve the timeout when server is concatenating the chunks into a single file
Contributor
|
@szaimen Nice. Could you kindly resolve conflicts manually and rebase it against the master branch? |
allexzander
approved these changes
Jul 28, 2021
Contributor
Author
|
/rebase |
Contributor
Author
|
Superseded by #3600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3313
Signed-off-by: szaimen szaimen@e.mail.de