Skip to content

Fix alignment of predefined status contents regardless of emoji fonts#4845

Merged
claucambra merged 1 commit into
masterfrom
bugfix/predefined-statuses-alignment
Aug 17, 2022
Merged

Fix alignment of predefined status contents regardless of emoji fonts#4845
claucambra merged 1 commit into
masterfrom
bugfix/predefined-statuses-alignment

Conversation

@claucambra

@claucambra claucambra commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

This should make the alignment correct with any set of emoji fonts

Plasma emoji fonts:

Screenshot_20220810_201705

macOS emoji fonts:

Screenshot 2022-08-10 at 20 23 50

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Aug 10, 2022
@codecov

codecov Bot commented Aug 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4845 (bedcfbd) into master (6746717) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4845      +/-   ##
==========================================
- Coverage   57.21%   57.20%   -0.01%     
==========================================
  Files         138      138              
  Lines       17144    17144              
==========================================
- Hits         9809     9808       -1     
- Misses       7335     7336       +1     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.03% <0.00%> (-0.15%) ⬇️

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/predefined-statuses-alignment branch from 735cee2 to bedcfbd Compare August 17, 2022 18:01
@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: Nextcloud-PR-4845-bedcfbd14c0323d8f4595249feb673bb702a21d1-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 622462f into master Aug 17, 2022
@claucambra claucambra deleted the bugfix/predefined-statuses-alignment branch August 17, 2022 18:34
@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants