Skip to content

Update webhook dispatch command for AIO - #15593

Open
EncryptedGiraffe wants to merge 3 commits into
nextcloud:masterfrom
EncryptedGiraffe:patch-1
Open

EncryptedGiraffe wants to merge 3 commits into
nextcloud:masterfrom
EncryptedGiraffe:patch-1

Conversation

@EncryptedGiraffe

Copy link
Copy Markdown

The listed command didn't work properly, had an unnecessary sudo inside the container, tried to open a TTY, and also duplicated the exec portion.

I've verified that this updated command works in a tmux session.

@susnux
susnux requested a review from szaimen September 8, 2026 23:30

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@szaimen szaimen added this to the Nextcloud 36 milestone Sep 21, 2026
@szaimen
szaimen enabled auto-merge September 21, 2026 19:57
@szaimen
szaimen disabled auto-merge September 21, 2026 20:04
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command is right! The new line lost its indent though, so the code block ends up empty and the build complains. Could you indent it by 3 spaces like the rest?

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@skjnldsv

Copy link
Copy Markdown
Member

Thanks! I fixed the indentation so the code block renders, the command itself was already right. The only thing left is DCO: commit f8fd6c8 is authored as hi@encryptedgiraffe.xyz but signed off as github@encryptedgiraffe.xyz. Could you re-sign it with the matching address (git rebase --signoff HEAD~3, then force-push)? Then it's good to merge.

EncryptedGiraffe and others added 3 commits November 19, 2026 14:29
The listed command didn't work properly, had an unnecessary sudo inside the container, tried to open a TTY, and also duplicated the exec portion.

I've verified that this updated command works in a tmux session.

Signed-off-by: EncryptedGiraffe <hi@encryptedgiraffe.xyz>
Signed-off-by: Encrypted Giraffe <hi@encryptedgiraffe.xyz>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: EncryptedGiraffe <github@encryptedgiraffe.xyz>
Signed-off-by: Encrypted Giraffe <hi@encryptedgiraffe.xyz>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Signed-off-by: Encrypted Giraffe <hi@encryptedgiraffe.xyz>
auto-merge was automatically disabled November 19, 2026 21:44

Head branch was pushed to by a user without write access

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants