Skip to content

docs(dev): validate and rate-limit outgoing mail in email.rst - #15708

Open
whoalin1 wants to merge 1 commit into
nextcloud:masterfrom
whoalin1:docs-email-validate-rate-limit
Open

whoalin1 wants to merge 1 commit into
nextcloud:masterfrom
whoalin1:docs-email-validate-rate-limit

Conversation

@whoalin1

@whoalin1 whoalin1 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

email.rst showed how to send mail but not how to avoid turning the instance into a spam relay.

  • Document validating recipients with IMailer::validateMailAddress() before send().
  • Point to #[UserRateLimit] / #[AnonRateLimit] or ILimiter (see security.rst programmatic rate limiting).
  • Warn that anonymous / public users must not freely make the instance send mail to a typed-in address.

Closes #15683

Test plan

  • Sphinx build of the developer manual succeeds for the email page
  • New Validate recipients and rate-limit sends section mentions validateMailAddress
  • Section references #[UserRateLimit] / #[AnonRateLimit] or ILimiter and links programmatic rate limiting
  • Warning covers anonymous / public users and typed-in addresses

AI disclosure

This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.

All commits carry an Assisted-by: Cursor:grok-4.7 trailer.

Assisted-by: Cursor:grok-4.7
Signed-off-by: whoalin1 <whoalin414@gmail.com>
@whoalin1
whoalin1 force-pushed the docs-email-validate-rate-limit branch from 13d9060 to d2611ec Compare October 9, 2026 14:12
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase: master added an "Email templates" section right where this goes. Also:

  • The warning sentence is hard to follow, could you rephrase it?
  • Could you add the namespace for #[UserRateLimit] / #[AnonRateLimit] and link them to the rate limiting section in controllers.rst?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Developer manual: validate and rate-limit outgoing mail in email.rst

2 participants