Repository navigation
Conversation
…e.rst Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <whoalin414@gmail.com>
8e6ac67 to
167d98a
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
skjnldsv
left a comment
There was a problem hiding this comment.
Sort directions aren't interpolated: orderBy() throws on anything other than ASC/DESC. And Repository::findBy() maps keys through the entity, so raw strings never reach the SQL. The column allowlist advice is good, could you fix those two parts?
Summary
database.rstshowedcreateNamedParameter()for values but not that column names and sort directions cannot be bound as parameters.orderBy()/select().matchexample mapping request input onto allowed identifiers.findBy()orderBykeys.Closes #15682
Test plan
matchfor column and sort direction allowlistsorderBy()/select()and RepositoryfindBy()AI disclosure
This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.
All commits carry an
Assisted-by: Cursor:grok-4.7trailer.