Repository navigation
Conversation
Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <whoalin414@gmail.com>
65fd472 to
c1515fc
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
skjnldsv
left a comment
There was a problem hiding this comment.
I think this goes the other way from what we said on #1858: if a proxy like oauth2_proxy only uses Nextcloud for login, the app never sees the token. The proxy itself holds the Bearer token though, so "only controls who can start the login" isn't right either. Could you frame it around who holds the token?
Summary
Closes #1858
Security considerations already say tokens have full account access. Add an explicit note that fronting an app with something like
oauth2_proxydoes not reduce that scope: Nextcloud still issues a privileged Bearer token.Test plan
admin_manual/configuration_server/oauth2.rstAI disclosure
This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.
All commits carry an
Assisted-by: Cursor:grok-4.7trailer.