Conversation
The style.css file was no longer loaded since the PDF viewer was adjusted to use the standard viewer app, so it can be removed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the Talk sidebar is shown the footer in public pages is moved into the "#app-content" element. However, by default the footer in public pages is a direct child of the body, so this needs to be taken into account when hiding the footer element, as the footer would not be moved if Talk is not enabled. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The main content minimum height is set in server styles to the full height minus the footer height. Due to this, when the footer is hidden the height of the main content needs to be adjusted to ensure that it takes all the available space. When the Talk sidebar is shown the page layout is adjusted, including the CSS styles, and that main content height is increased as needed. However, when the Talk sidebar is not shown the height is not increased, so there is a blank area below the main content. Unfortunately it is not possible to just set an explicit height, as the needed height is different depending on whether the Talk sidebar is shown or not. No matter if the Talk sidebar is shown or not the main content height just needs to fill the available space, so now this is done using flexbox. This avoids having to set an explicit height and thus works for both the standard layout and the Talk sidebar layout. Moreover, even if an explicit height is set somewhere, like in the server or Talk styles, the flex-grow property implicitly overrides it and ensures that the main content will fill the available height. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
skjnldsv
approved these changes
Jun 28, 2022
skjnldsv
deleted the
backport/615/stable22-fix-footer-not-hidden-when-talk-sidebar-is-not-shown
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Kind of) Backport of #615