Change view design from dark to light

[jancborchardt]

@LukasReschke for some reason the CSS isn’t updated. To I need to compile something? (If so, we should add that to the readme.)

[LukasReschke]

@LukasReschke for some reason the CSS isn’t updated. To I need to compile something? (If so, we should add that to the readme.)

Define "the CSS"

[jancborchardt]

@LukasReschke the changes I made. Do you see them?

[jancborchardt]

@nextcloud/designers you want to check this out?

[MorrisJobke]

👎 no header bar for closing the PDF is missing

[MorrisJobke]

please rebase

[jancborchardt]

Rebased and fixed some last details. Ready to review @nextcloud/designers @nextcloud/javascript @LukasReschke @MorrisJobke

[MorrisJobke]

Doesn't work with IE11 and Edge:

[jancborchardt]

TODO:

• to make it work in IE, manually color-invert all icons instead of using CSS inversion, and then override the originals via CSS 😒

[MariusBluem]

What is the current state here?

[MorrisJobke]

What is the current state here?

I guess it's "abandoned" -.-

[MorrisJobke]

Nothing for 12 -> moved to 13.

[MorrisJobke]

Moved to 14.

[jancborchardt]

@juliushaertl @skjnldsv as you are more knowledgeable about the whole color inversion stuff, do you have any idea here?

[MorrisJobke]

Moved to 15

[juliusknorr]

This is nothing that will be done til tomorrow so I'd say we move it to 16, but I'll look into it.

[jancborchardt]

For reference, these are the related issues in Mozilla’s PDF.js repository:

• Themes & Skins for pdf.js Themes & Skins for pdf.js mozilla/pdf.js#3528
• Replace PNG assets with SVG assets Replace PNG assets with SVG assets mozilla/pdf.js#6252

They seem welcoming towards contributions for theming, and lots of people ask for it. So if we do something here it might be good to look at upstreaming it. @juliushaertl let’s sit together at the Contributor Week?

[skjnldsv]

OUtdated