Conversation
There was a problem hiding this comment.
I think it would be good to mention realm-name example as opnc
There was a problem hiding this comment.
should we mention to check I have a discovery endpoint URL as I don't have this information is checked by default and it might be confusing where to put discovery endpoint
There was a problem hiding this comment.
we are following the sequential actions , so do we need to tell to complete those sequential steps?
| - Client secret: Client secret of openproject from keycloak | ||
| - [ ] Login as keycloak-created user in `Openproject`. | ||
| - [ ] Log out, then Login as admin in `Openproject`. | ||
| - [ ] As an `OpenProject` admin, add keycloak-created user as a member in one of the project. |
There was a problem hiding this comment.
i think we should also add a storage in the project settings -> files in later step
There was a problem hiding this comment.
what about going to the nextcloud, navigate to Administration settings> OpenProject , then put openproject url, select oauth (selected by default) first before copying the credentials
| - [ ] In `Nextcloud`, navigate to `Personal Settings > Openproject` and click on `Connect to OpenProject` button. | ||
| - [ ] `Nextcloud` admin should be connected as an `OpenProject` admin. | ||
| - [ ] Also, create a user in both `Nextcloud` as well as `OpenProject`. | ||
| - [ ] From the personal section of the created user in `Nextcloud`, connect to `OpenProject`. |
There was a problem hiding this comment.
login as created user and from the settings -> connect...
There was a problem hiding this comment.
Why is it needed?
| ### A3. Add File storage (Nextcloud) to an OpenProject project | ||
| - [ ] Complete step [Test No A1](#a1-oauth-configuration). | ||
| - [ ] Select an `OpenProject` Project (for example, `Demo Project`) in `OpenProject`. | ||
| - [ ] Navigate to `Project settings > Files` of `Demo Project`. | ||
| - [ ] Add a file storage name `Nextcloud`( choose `No specific Folder` option ) for `Demo Project`. |
There was a problem hiding this comment.
this action is done by admin, its confusing as in the A2 section, created user is logged in, and this A3 section requires to be logged in as an admin
| @@ -53,5 +54,5 @@ | |||
| ### A3. Add File storage (Nextcloud) to an OpenProject project | |||
| - [ ] Complete step [Test No A1](#a1-oauth-configuration). | |||
| - [ ] Select an `OpenProject` Project (for example, `Demo Project`) in `OpenProject`. | |||
There was a problem hiding this comment.
what is wrong here i don't understand?
There was a problem hiding this comment.
its good to mention in openproject and as an admin
There was a problem hiding this comment.
we have already created user created in above steps
| @@ -67,23 +68,8 @@ | |||
| - [ ] Try to connect the created `OpenProject` user as created `Nextcloud` user. | |||
There was a problem hiding this comment.
this action is done by created user, so we need to login as created user in both openproject and nextcloud first
There was a problem hiding this comment.
The reader will understand that logging in is required to perform this test. So, I think it is clear
There was a problem hiding this comment.
would be good to clarify we have to go to the nextcloud as an openproject user -> settings -> openproject -> connect to openproject (we need to be logged in as created user in openproject too)
There was a problem hiding this comment.
we can click on the respective ID rather than double click as double clicking around the text area selects the text which is annoying
There was a problem hiding this comment.
rather than saying open the form, search for work package -> create and link a new work package , in nextcloud
|
|
||
| ### 6. Check New folder with automatically managed permissions in OpenProject | ||
| #### 6. Setup and check project folder in Nextcloud (with project folder setup) | ||
| - [ ] Enable `groupfolders` application in `Nextcloud`. |
There was a problem hiding this comment.
would be good to mention how to enable it in short
| - [ ] Enable `Automatically managed folders` switch in admin setting and set project folder. | ||
| - [ ] Application password should be generated. |
There was a problem hiding this comment.
Then copy and paste the generated application password from nextcloud to openproject
|
|
||
| ### 6. Check New folder with automatically managed permissions in OpenProject | ||
| #### 6. Setup and check project folder in Nextcloud (with project folder setup) | ||
| - [ ] Enable `groupfolders` application in `Nextcloud`. |
| ### 6. Check New folder with automatically managed permissions in OpenProject | ||
| #### 6. Setup and check project folder in Nextcloud (with project folder setup) | ||
| - [ ] Enable `groupfolders` application in `Nextcloud`. | ||
| - [ ] Enable `Automatically managed folders` switch in admin setting and set project folder. |
| - [ ] Enable `groupfolders` application in `Nextcloud`. | ||
| - [ ] Enable `Automatically managed folders` switch in admin setting and set project folder. | ||
| - [ ] Application password should be generated. | ||
| - [ ] Verify that `OpenProject` user and group are created with user `OpenProject` as sub-admin of the group. |
There was a problem hiding this comment.
OpenProject user and OpenProject group
| - [ ] Application password should be generated. | ||
| - [ ] Verify that `OpenProject` user and group are created with user `OpenProject` as sub-admin of the group. | ||
| - [ ] Verify that `OpenProjectNoAutomaticProjectFolders` group is also created with user `OpenProject` as sub-admin. | ||
| - [ ] Try deleting `OpenProject` user and group, those should not be deleted. |
There was a problem hiding this comment.
| - [ ] Enable `groupfolders` application in `Nextcloud`. | ||
| - [ ] Enable `Automatically managed folders` switch in admin setting and set project folder. | ||
| - [ ] Application password should be generated. | ||
| - [ ] Verify that `OpenProject` user and group are created with user `OpenProject` as sub-admin of the group. |
There was a problem hiding this comment.
#### 6. Setup and check project folder in Nextcloud (with project folder setup)
this step heading itself mentioned in nextcloud. so, i don't think we need to again mention here again.
| - [ ] Enable `Automatically managed folders` switch in admin setting and set project folder. | ||
| - [ ] Application password should be generated. | ||
| - [ ] Verify that `OpenProject` user and group are created with user `OpenProject` as sub-admin of the group. | ||
| - [ ] Verify that `OpenProjectNoAutomaticProjectFolders` group is also created with user `OpenProject` as sub-admin. |
There was a problem hiding this comment.
same comment
There was a problem hiding this comment.
these names OIDC Identity Provider and OpenID Connect user backend would be helpful
| - [ ] Go to `Administation > OpenID Connect Provider` | ||
| - Click the button `+ Add client`: | ||
| - Add a client name (not an identifier) such as `openproject` | ||
| - Add a redirect URL (<openproject_host>/auth/oidc-<idp-displayname-from-OP>/callback) |
There was a problem hiding this comment.
| - Add a redirect URL (<openproject_host>/auth/oidc-<idp-displayname-from-OP>/callback) | |
| - Add a redirect URL (<openproject_host>/auth/oidc-<idp-displayname-from-openproject>/callback) |
| - [ ] Run following command: | ||
| - `php occ config:system:set user_oidc --type boolean --value="true" oidc_provider_bearer_validation` |
There was a problem hiding this comment.
good to mention its needed for only local setup
There was a problem hiding this comment.
may be sometime missing in other setup also
There was a problem hiding this comment.
best would be to explain why this command is needed in the first place and what it does
There was a problem hiding this comment.
added this:
- Note: This enables bearer token validation for `user_oidc`. Without it, login or connection may fail. This may also be missing during local setups.|
|
||
| #### B.1.2. Add Nextcloud IDP in OpenProject | ||
| #### B.1.2. Add Nextcloud IDP in OpenProject (Without project folder setup) | ||
| - [ ] In OpenProject, go to `Administration > Authentication > OpenID providers` |
There was a problem hiding this comment.
we need to add an Enterprise token before this step
There was a problem hiding this comment.
Done! I have mentioned it before starting the sso tests
| - [ ] In nextcloud, go to `Administration > OpenProject`. | ||
| - [ ] Under `Authentication Method`, select `Single-Sign-On through OpenID Connect Identity Provider`. | ||
| - [ ] In `Authentication settings`, select `provider Type` as `Nextcloud Hub`. | ||
| - [ ] Set Openproject `client ID` by Client ID copied earlier in **Test No B1**. |
There was a problem hiding this comment.
also uncheck project folder (automatically managed folder).
f225fdc to
cec9972
Compare
| - [ ] `OpenProject` admin is connected to `Nextcloud` as a `Nextcloud` admin. | ||
| - [ ] Also, create a user in both `Nextcloud` as well as `OpenProject`. | ||
| - [ ] Add the created `OpenProject` user as the member of `Demo Project` project (admin can add members to a project). | ||
| - [ ] Try to connect the created `OpenProject` user as created `Nextcloud` user. |
There was a problem hiding this comment.
| - [ ] Try to connect the created `OpenProject` user as created `Nextcloud` user. | |
| - [ ] Login as created user in both openproject and nextcloud | |
| - [ ] Try to connect the created `OpenProject` user as created `Nextcloud` user. |
cec9972 to
16c3300
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
16c3300 to
eb52330
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
eb52330 to
c9b81f4
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Description
This PR updates the smoke testing documents.
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile