Conversation
GretaD
force-pushed
the
enhancement/nc_23_compatibility
branch
from
0bf8f1c to
e33fc31
Compare
Member
|
info.xml doesn't allow 23 yet |
Contributor
Author
because i need to change this: https://github.com/nextcloud/mail/blob/master/appinfo/info.xml#L37 |
Member
yes. That will bite us as soon as they've updated https://github.com/nextcloud/server/blob/4e9727037220a8acddf7a3478a047c0bc6fc4bae/version.php#L33 to say 23 |
Contributor
Author
Member
GretaD
force-pushed
the
enhancement/nc_23_compatibility
branch
from
b056eff to
998f71f
Compare
Signed-off-by: greta <gretadoci@gmail.com>
GretaD
force-pushed
the
enhancement/nc_23_compatibility
branch
from
998f71f to
5c09c89
Compare
ChristophWurst
approved these changes
Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thats all i need to change, right?