Skip to content

[1419] - Migrate from onCreateOptionMenu to implements MenuProvider#1426

Open
WentuM wants to merge 1 commit intonextcloud:masterfrom
WentuM:refactor-1419/migrate_to_menu_provider
Open

[1419] - Migrate from onCreateOptionMenu to implements MenuProvider#1426
WentuM wants to merge 1 commit intonextcloud:masterfrom
WentuM:refactor-1419/migrate_to_menu_provider

Conversation

@WentuM
Copy link

@WentuM WentuM commented May 10, 2024

Implements MenuProvider instead of use onCreateOptionMenu (deprecated)

@David-Development
Copy link
Member

@WentuM Sorry for the delay - had some personal things to take care of! Thank you for contributing to this app!
I've reviewed and tested the changes (which are looking great) - unfortunately it's not working for me - the app doesn't have any menus anymore. It looks like that the call to addMenuProvider(this, this); in the Activities onCreate method is missing. Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants