Add admin setting page with users defaults#1266
Add admin setting page with users defaults#1266nickvergessen merged 16 commits intonextcloud:masterfrom
Conversation
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Looks good in general, but didn't test yet. Just wanted to quickly give the feedback after my vacation
|
Hello, @nickvergessen. I don't see any of those changes in recent releases. Is there something wrong with it? |
You don't see it because we didn't merge it.
Didn't have time to check it yet, but a review is queued for this week. |
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: natoponen <57988162+natoponen@users.noreply.github.com> Signed-off-by: Топонен Никита <Toponen@lanit.ru>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: natoponen <57988162+natoponen@users.noreply.github.com> Signed-off-by: Топонен Никита <Toponen@lanit.ru>
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
nickvergessen
force-pushed
the
master
branch
from
425bd9d to
6809886
Compare
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Coding styles seem off, but should be auto-fixable:
composer run cs:fix
npm run lint:fix
afterwards confirm with:
composer run cs:check
npm run lint
Other then that there are some minor comments but it works fine. If you can't or don't want to take care of the remaining points we can also do that.
| form.append('batchSetting', this.config.setting_batchtime) | ||
| form.append('soundNotification', this.config.sound_notification ? 'yes' : 'no') | ||
| form.append('soundTalk', this.config.sound_talk ? 'yes' : 'no') | ||
| await axios.post(generateOcsUrl('apps/notifications/api/v2/settings/admin'), form) |
There was a problem hiding this comment.
Instead of adding our own API call + endpoint here we could use
OCP.AppConfig.setValue()
But then it's not possible to have a sub admin permission for this, although I'm not convinced that would be necessary at all
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Fixed the open comments
|
Thanks for all the hard work @natoponen and sorry for the delay on the review |
|
/backport to stable25 |
4 participants
Closing #1173 #1260 by adding admin's setting page for configuring user defaults, which will be applied on UserCreatedEvent or PostLoginEvent, if existing user doesn't have settings yet.
Not sure whether I should add author,copyright and license terms in the beggining of new files. Hope you can help me here :)