Use vue-richtext instead of handlebars#727
Merged
nickvergessen merged 8 commits intomasterfrom Sep 3, 2020
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
juliusknorr
reviewed
Sep 2, 2020
| - along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| --> | ||
|
|
||
| <template> |
Member
There was a problem hiding this comment.
For later we could also have those in a library, since they would be reusable then for any ui that uses the rich object string definitions from the server
Member
Author
There was a problem hiding this comment.
yeah, specially the empty default would be nice I guess.
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
changed the title
Signed-off-by: Joas Schilling <coding@schilljs.com>
juliusknorr
reviewed
Sep 3, 2020
| }, | ||
| absoluteDate: function() { | ||
| return OC.Util.formatDate(this.timestamp) | ||
| return OC.Util.formatDate(this.timestamp, 'LLL') |
Member
There was a problem hiding this comment.
OC.Util.formatDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment
juliusknorr
approved these changes
Sep 3, 2020
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Small deprecation comment but fine to tackle that in a separate pr of course. Otherwise 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #412
Fix #427