Skip to content

refactor: Port hooks to IUserManager::getUserNameFromLoginName #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarlSchwan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Port hooks to IUserManager::getUserNameFromLoginName #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/ComplianceService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ class ComplianceService {
public function __construct(
private ContainerInterface $container,
private LoggerInterface $logger,
private IUserSession $userSession,
private IConfig $config,
private ISession $session,
private IUserManager $userManager,
) {
}
Expand All @@ -57,8 +54,7 @@ public function audit(IUser $user, string $password): void {
* @throws LoginException
*/
public function entryControl(string $loginName, ?string $password): void {
$uid = $loginName;
\OCP\Util::emitHook('\OCA\Files_Sharing\API\Server2Server', 'preLoginNameUsedAsUserName', ['uid' => &$uid]);
$uid = $this->userManager->getUserNameFromLoginName($loginName);

/** @var IEntryControl $instance */
foreach ($this->getInstance(IEntryControl::class) as $instance) {
Expand Down
5 changes: 0 additions & 5 deletions tests/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@
<code><![CDATA[setUserValue]]></code>
</DeprecatedMethod>
</file>
<file src="lib/ComplianceService.php">
<DeprecatedMethod>
<code><![CDATA[\OCP\Util::emitHook('\OCA\Files_Sharing\API\Server2Server', 'preLoginNameUsedAsUserName', ['uid' => &$uid])]]></code>
</DeprecatedMethod>
</file>
<file src="lib/FailedLoginCompliance.php">
<DeprecatedMethod>
<code><![CDATA[getUserValue]]></code>
Expand Down
Loading