Fix 'source' URL in viewer #1419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure 'filename' is consistent and includes app and user Signed-off-by: Juergen Kellerer <[email protected]>
skjnldsv
requested changes
Oct 26, 2022
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Blocking, I'm investigating a different approach from Viewer for 26, we'll see if that is really necessary to have that heavy changes to fix things :)
skjnldsv
added
2. developing
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced May 3, 2023
This was referenced Mar 12, 2024
Collaborator
|
The situation should be better since the switch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concentrates on
filenamebeing consistent and includes app and user so that source URL can be built properly. This allows to use the full viewer (with fileInfo as input) at more places.Prior to this change, source URL could be invalid and this broke sidebar, download and file-editing in the Viewer. The URL derives from
filenamebut this was not consistently built (sometimes with, sometimes without prefix).Since the viewer may also need different paths, all input to the viewer is mapped so that it can be adjusted as needed (at a single place).
Note: In my tests albums views still had an issue (e.g. forcing the use of the URL with
hasPreview: falsefails), but this may be related to nextcloud/viewer#1282